Ticket #48 (closed enhancement: fixed)

Opened 1 year ago

Last modified 1 year ago

Patch to use AM_CPPFLAGS instead of CPPFLAGS in src/Makefile.am

Reported by: swapoff.20.aarre@spamgourmet.com Assigned to: athomas
Priority: trivial Component: DevTodo
Severity: trivial Keywords:
Cc:

Description

Defining CPPFLAGS in Makefile.am causes problems if a user happens to already have CPPFLAGS set, as shown below. Using AM_CPPFLAGS instead achieves the same effect while gracefully handling the case where the user has CPPFLAGS set. A patch is attached to make this trivial change. 

aarre@ganesha ~/src/ext/devtodo/trunk
$ ./autogen.sh 
libtoolize
aclocal
automake
configure.in: installing `./install-sh'
configure.in: installing `./missing'
src/Makefile.am:11: CPPFLAGS was already defined in condition TRUE, which includes condition DEBUG ...
configure.in:9: ... `CPPFLAGS' previously defined here
src/Makefile.am: installing `./depcomp'
src/Makefile.am:11: `CPPFLAGS' is a user variable, you should not override it;
src/Makefile.am:11: use `AM_CPPFLAGS' instead.
src/Makefile.am:13: `CPPFLAGS' is a user variable, you should not override it;
src/Makefile.am:13: use `AM_CPPFLAGS' instead.
configure.in:88: required file `config.h.in' not found

Attachments

cppflags.patch (317 bytes) - added by swapoff.20.aarre@spamgourmet.com on 06/22/07 21:26:44.
Patch

Change History

06/22/07 21:26:44 changed by swapoff.20.aarre@spamgourmet.com

  • attachment cppflags.patch added.

Patch

06/28/07 06:18:39 changed by athomas

  • status changed from new to closed.
  • resolution set to fixed.

(In [442]) Applied patch from swapoff.20.aarre@spamgourmet.com, closes #48. Thanks :)

Add/Change #48 (Patch to use AM_CPPFLAGS instead of CPPFLAGS in src/Makefile.am)




Change Properties
Action