properly escape '?'

[okan@…]

need to properly escape '?' so that some regex implementations don't complain about a repetition operator error; but really, '?' should be escaped anyway.

without this, no xml database may be read.

[athomas]

The ? is a modifier for * to prevent a greedy match. On what system did you see this error?

[anonymous]

Replying to athomas:

The ? is a modifier for * to prevent a greedy match. On what system did you see this error?

OpenBSD. i tried on FreeBSD as well with the same result.

basically, the thing compiles. once an xml database is created, devtodo can't read it due to the regex pattern sent to regcomp().

from our regex(3):

A repetition operator (?, *, +, or bounds) cannot follow another repeti- tion operator. A repetition operator cannot begin an expression or subexpression or follow ^' or |'.

i now see what you meant by using '?' as to control the greediness, and not to match the last '?' in the spec.

[okan@…]

how about: "<\\?xml[^{\\?].*\\?>[[:space:]]*" instead?}

[okan@…]

Replying to okan@demirmen.com:

how about: "<\\?xml[^{\\?].*\\?>[[:space:]]*" instead?}

uhm, wiki ate my last one:

"<\\?xml[^\\?].*\\?>[[:space:]]*"

[athomas]

Yeah, that looks good to me.

[athomas]

Fixed in r491, thanks!